Handle empty string input for parseBase64Binary instead of throwing IllegalArgumentException #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanderHestvik
changed the title
|
@SanderHestvik @lukasj public static byte[] _parseBase64Binary(String text) {
if (null == text || text.length() % 4 != 0) {
throw new IllegalArgumentException("base64 text invalid.");
}Then you could modify your PR changing with this snippet and delete the next if condition. In addition to, you could add new asserts including RFC references: Assert.assertEquals("", new String(DatatypeConverter.parseBase64Binary("")));
Assert.assertEquals("f", new String(DatatypeConverter.parseBase64Binary("Zg==")));
Assert.assertEquals("fo", new String(DatatypeConverter.parseBase64Binary("Zm8=")));
Assert.assertEquals("foo", new String(DatatypeConverter.parseBase64Binary("Zm9v")));
Assert.assertEquals("foob", new String(DatatypeConverter.parseBase64Binary("Zm9vYg==")));
Assert.assertEquals("fooba", new String(DatatypeConverter.parseBase64Binary("Zm9vYmE=")));
Assert.assertEquals("foobar", new String(DatatypeConverter.parseBase64Binary("Zm9vYmFy")));Regards, |
…tps://www.rfc-editor.org/rfc/rfc4648#section-10 Co-authored-by: Antonio Santos Izaguirre <[email protected]>
|
@lukasj Could you merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, after #282, parseBase64Binary throws IllegalArgumentException when called with an empty string
Reading through https://www.w3.org/TR/xmlschema-2 it seems like this is valid input
There is even a test vector
BASE64("") = ""in https://www.rfc-editor.org/rfc/rfc4648#section-10https://github.com/jakartaee/jaxb-api/pull/282/files#diff-2eef69682cb2debd3c0bb837aceb2da7d800a9145e133c709f9e9fb6ef0c3391L707-L710
Let me know if you would like me to create another PR adding some more test coverage